Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise the interface of a protocol. #473

Merged
merged 8 commits into from
Sep 18, 2024
Merged

Revise the interface of a protocol. #473

merged 8 commits into from
Sep 18, 2024

Conversation

guoshiuan
Copy link
Collaborator

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 10, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10913366390

Details

  • 47 of 177 (26.55%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 2.879%
Changes Missing Coverage Covered Lines Changed/Added Lines %
dataplane/dplanerc/interface.go 0 14 0.0%
dataplane/protocol/lldp/lldp.go 47 163 28.83%
Totals Coverage Status
Change from base Build 10891261368: 0.007%
Covered Lines: 18967
Relevant Lines: 658749
💛 - Coveralls

DanG100
DanG100 approved these changes Sep 17, 2024
View reviewed changes
dataplane/dplanerc/interface.go Show resolved Hide resolved
dataplane/dplanerc/interface.go Outdated Show resolved Hide resolved
dataplane/protocol/lldp/lldp.go Outdated Show resolved Hide resolved
dataplane/protocol/lldp/lldp.go Outdated Show resolved Hide resolved
dataplane/protocol/lldp/lldp.go Show resolved Hide resolved
@guoshiuan guoshiuan merged commit 2f9ec57 into main Sep 18, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanG100 DanG100 DanG100 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guoshiuan @DanG100