Support set-local-pref and set-med #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored community-set test for testing other attributes. * There is now only one policy-setting phase for simplification. * Each route has its own policy statement switch case block for creating related policies.
wenovus
changed the title
|
Verified integration tests locally using |
DanG100
reviewed
Aug 24, 2023
| var installRejectStmt bool | ||
| rejectStmt := &oc.RoutingPolicy_PolicyDefinition_Statement{Name: ygot.String(route + "-reject-policy")} | ||
|
|
||
| switch i { |
There was a problem hiding this comment.
this isn't very clear. i don't see why i == 1 means set communites
There was a problem hiding this comment.
Added a comment. Each index refers to an input test route, and each one has its corresponding policies that applies to it. Each one is essentially a subtest that re-uses the topology.
Pull Request Test Coverage Report for Build 5978619732
💛 - Coveralls |
DanG100
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored community-set test for testing other attributes: