Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Policy Tests #237

Merged
merged 10 commits into from
Aug 25, 2023
Merged

Refactor Policy Tests #237

merged 10 commits into from
Aug 25, 2023

Conversation

wenovus
Copy link
Contributor

@wenovus wenovus commented Aug 22, 2023

  • Expanded generic policy_test topology to accommodate different tests.
  • Factored out route propagation checking logic, which now can also check a new NOT_PREFERRED state.
  • lemming device creation is done more automatically, with each listening only on its own address instead of on all addresses.
  • Parallelize session establishment.
  • community_set_test.go will be deleted in the next PR so can skip reviewing that.
  • Install filtering policies on the import side due to GoBGP not supporting route withdrawals when soft-resetting on the export side.

@wenovus wenovus marked this pull request as ready for review August 23, 2023 15:09
@wenovus wenovus requested a review from DanG100 August 23, 2023 15:09
@wenovus wenovus marked this pull request as draft August 23, 2023 16:04
@wenovus wenovus removed the request for review from DanG100 August 23, 2023 16:04
@wenovus
Copy link
Contributor Author

wenovus commented Aug 23, 2023

Converting to a draft for now to see if the test time can be reduced, and potentially remove test from running on GitHub.

@wenovus wenovus marked this pull request as ready for review August 24, 2023 17:34
@wenovus wenovus requested a review from DanG100 August 24, 2023 17:34
@wenovus
Copy link
Contributor Author

wenovus commented Aug 24, 2023

I noticed the "update is stale" error when running the BGP integration tests locally under high CPU load. I haven't seen it locally otherwise.

@DanG100
Copy link
Collaborator

DanG100 commented Aug 24, 2023

//integration_tests/twodut_oneotg_tests/bgp_redistribution:bgp_redistribution_test is failing locally on my machine can you take a look

@wenovus
Copy link
Contributor Author

wenovus commented Aug 24, 2023

The "update is stale" error is appearing now on GCB as well. I will investigate this later. It's clear it's not just happening on GitHub.

@wenovus wenovus merged commit e02a16a into main Aug 25, 2023
7 of 8 checks passed
@wenovus wenovus deleted the refactor-policy-tests branch August 25, 2023 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants