Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor apigen package and check in generated protos #228

Merged
merged 5 commits into from
Aug 15, 2023
Merged

Conversation

DanG100
Copy link
Collaborator

@DanG100 DanG100 commented Aug 14, 2023

Functionality is the same

  • docparser contains logic for parsing xml
  • protogen contains proto gen
  • saiast contains logic for parsing the ast

@github-actions
Copy link

github-actions bot commented Aug 14, 2023

Pull Request Test Coverage Report for Build 5869545199

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 2.499%

Totals Coverage Status
Change from base Build 5869414560: 0.0%
Covered Lines: 13215
Relevant Lines: 528735

💛 - Coveralls

dataplane/standalone/apigen/docparser/docparser.go Outdated Show resolved Hide resolved
dataplane/standalone/apigen/saiast/saiast.go Outdated Show resolved Hide resolved
@DanG100 DanG100 merged commit 7002603 into main Aug 15, 2023
7 of 8 checks passed
@DanG100 DanG100 deleted the proto-gen-part5 branch August 15, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants