Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

system_base_test: run TestGNMIClient for defined path #3674

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

brianneville
Copy link

In PR #2855 the commit
87f3397 made a change to the path being requested when the connection is being tested.
Previously an empty GetRequest was being sent, which meant that the GetResponse would also be empty.
This was changed so that now the test is requesting the root node.

However, its possible that the GetResponse for the root node is larger than the maximum response size for which the client is configured (i.e. the gRPC default max response size of 4MiB)

To get around this we should run the request to a defined path so that we are guaranteed a small response. The response is ignored anyway, so it doesnt matter what path we request here.

The /system/config/hostname is used as this path is used in other featureprofile tests
(e.g. feature/system/tests/system_base_test/hostname_test.go), so all vendors should have support for it.

In PR openconfig#2855 the commit
openconfig@87f3397
made a change to the path being requested when the 
connection is being tested. Previously an empty GetRequest was being sent,
which meant that the GetResponse would also be empty.
This was changed so that now the test is requesting the root node.

However, its possible that the GetResponse for the root node is larger than
the maximum response size for which the client is configured (i.e. the gRPC 
default max response size of 4MiB)

To get around this we should run the request to a defined path so that
we are guaranteed a small response. The response is ignored
anyway, so it doesnt matter what path we request here.

The /system/config/hostname is used as this path is used
in other featureprofile tests 
(e.g. feature/system/tests/system_base_test/hostname_test.go),
so all vendors should have support for it.
@brianneville brianneville requested a review from a team as a code owner January 2, 2025 12:43
@OpenConfigBot
Copy link

OpenConfigBot commented Jan 2, 2025

Pull Request Functional Test Report for #3674 / 6cf1c32

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
System-1: System testing
Cisco 8000E status
System-1: System testing
Cisco XRd status
System-1: System testing
Juniper ncPTX status
System-1: System testing
Nokia SR Linux status
System-1: System testing
Openconfig Lemming status
System-1: System testing

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
System-1: System testing
Cisco 8808 status
System-1: System testing
Juniper PTX10008 status
System-1: System testing
Nokia 7250 IXR-10e status
System-1: System testing

Help

@coveralls
Copy link

coveralls commented Jan 2, 2025

Pull Request Test Coverage Report for Build 12590732749

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.268%

Totals Coverage Status
Change from base Build 12578858218: 0.0%
Covered Lines: 1983
Relevant Lines: 3588

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants