system_base_test: run TestGNMIClient for defined path #3674
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR #2855 the commit
87f3397 made a change to the path being requested when the connection is being tested.
Previously an empty GetRequest was being sent, which meant that the GetResponse would also be empty.
This was changed so that now the test is requesting the root node.
However, its possible that the GetResponse for the root node is larger than the maximum response size for which the client is configured (i.e. the gRPC default max response size of 4MiB)
To get around this we should run the request to a defined path so that we are guaranteed a small response. The response is ignored anyway, so it doesnt matter what path we request here.
The /system/config/hostname is used as this path is used in other featureprofile tests
(e.g. feature/system/tests/system_base_test/hostname_test.go), so all vendors should have support for it.