Modified TC5 final port up check as timing was causing flaky results #3662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Functional Test Report for #3662 / dcce4ecVirtual Devices
Hardware Devices
|
self-maurya
previously approved these changes
Jan 6, 2025
Pull Request Test Coverage Report for Build 12629759977Details
💛 - Coveralls |
self-maurya
approved these changes
Jan 6, 2025
ram-mac
approved these changes
Jan 6, 2025
ampattan
pushed a commit
to nokia/featureprofiles
that referenced
this pull request
Jan 17, 2025
…penconfig#3662) * modifed TC5 final port up check as timing was causing flaky results * Update README.md --------- Co-authored-by: Pramod Maurya <[email protected]>
alshabib
pushed a commit
to alshabib/featureprofiles
that referenced
this pull request
Jan 19, 2025
…penconfig#3662) * modifed TC5 final port up check as timing was causing flaky results * Update README.md --------- Co-authored-by: Pramod Maurya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR increases the final verification wait time in the TC5 "short down" scenario from 10 seconds to 30 seconds. The README does not mandate strict upper limits for this step, only that the interface should be stable after the short down event. Extending the wait time provides a sufficient buffer to confirm that the DUT has fully settled in the "UP" state, reducing test flakiness without violating any documented requirements.