Adding deviation for rate class unsupport option for the ETH channel configuration #3660
+1,126
−1,083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ankur19
reviewed
Dec 19, 2024
internal/cfgplugins/interface.go
Outdated
| Index: ygot.Uint32(ethIndex), | ||
| LogicalChannelType: oc.TransportTypes_LOGICAL_ELEMENT_PROTOCOL_TYPE_PROT_ETHERNET, | ||
| TribProtocol: oc.TransportTypes_TRIBUTARY_PROTOCOL_TYPE_PROT_400GE, | ||
| RateClass: oc.TransportTypes_TRIBUTARY_RATE_CLASS_TYPE_TRIB_RATE_400G, |
There was a problem hiding this comment.
Apply if else only in the RateClass field.
| @@ -38,6 +38,7 @@ message Metadata { | |||
| TESTBED_DUT_DUT_ATE_2LINKS = 6; | |||
| TESTBED_DUT_ATE_8LINKS = 7; | |||
| TESTBED_DUT_400ZR = 8; | |||
| TESTBED_DUT_400ZR_PLUS = 9; | |||
There was a problem hiding this comment.
Also need to add testbed file here: https://github.com/openconfig/featureprofiles/tree/main/topologies
self-maurya
previously approved these changes
Jan 6, 2025
… does not support this yet
…a device does not support this yet" This reverts commit b1af1fc.
self-maurya
force-pushed
the
jchenjian-g/OC_github
branch
from
fe2f0c4 to
bde1657
Compare
self-maurya
approved these changes
Jan 6, 2025
Pull Request Test Coverage Report for Build 12627191675Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arista does not support rate class setting yet, hence adding a deviation in the ConfigETHChannel function in the interface.go file as well as the corresponding changes in the deviations.go file.