TRANSCEIVER-12 Fixed with adding required deviations #3638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-deviation `require_zr_oper_mode` --> https://partnerissuetracker.corp.google.com/issues/383369830 -deviation `explicit_dco_config` --> https://partnerissuetracker.corp.google.com/issues/383075189 "This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
Pull Request Test Coverage Report for Build 12712751781Details
💛 - Coveralls |
|
Attached HwIXR10-e execution logs in https://partnerissuetracker.corp.google.com/issues/383666725 |
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
snaragund
requested review from
jianchen-g,
yiwenhu-g,
ahsaanyousaf,
ejbrever and
rezachit
as code owners
cfernanz
previously approved these changes
Dec 26, 2024
ahsaanyousaf
previously approved these changes
Jan 7, 2025
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
ahsaanyousaf
previously approved these changes
Jan 7, 2025
ejbrever
reviewed
Jan 16, 2025
| }, | ||
| }) | ||
| } | ||
| if deviations.RequireZrOperMode(dut) { |
There was a problem hiding this comment.
We should not encode specific implementation's oper-mode's here.
If you want to specify a specific oper-mode, this should be done through a flag in the tests. As an example:
| }, | ||
| }) | ||
| } | ||
| if deviations.RequireZrOperMode(dut) { |
There was a problem hiding this comment.
I think we should be using ConfigOpticalChannel() here and then we don't need a deviation?
There was a problem hiding this comment.
I can set this up calling ConfigOpticalChannel() under InterfaceConfig(); however will this have any negative impact on existing implementation of other vendors where the oper-mode may be self-discovered?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
require_zr_oper_mode--> https://partnerissuetracker.corp.google.com/issues/383369830explicit_dco_config--> https://partnerissuetracker.corp.google.com/issues/383075189"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."