Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use base64-encoded DER PinnedDomainCert in OwnershipVoucher instead of PEM format. #86

Merged
merged 6 commits into from
Oct 30, 2023
Merged

Use base64-encoded DER PinnedDomainCert in OwnershipVoucher instead of PEM format. #86

merged 6 commits into from
Oct 30, 2023

Conversation

gmacf
Copy link
Contributor

@gmacf gmacf commented Oct 26, 2023

This removes the need to manually add and remove PEM headers.

closes #69

@gmacf gmacf changed the title Use []byte type for PinnedDomainCert in OwnershipVoucher. Use base64-encoded DER PinnedDomainCert in OwnershipVoucher instead of PEM format. Oct 30, 2023
@gmacf gmacf requested review from chuckx and melzhan and removed request for chuckx October 30, 2023 01:08
@gmacf gmacf linked an issue Oct 30, 2023 that may be closed by this pull request
datetime format in the ownership voucher #89
Closed
@gmacf gmacf merged commit 6575eb8 into openconfig:main Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chuckx chuckx chuckx left review comments

@melzhan melzhan melzhan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

datetime format in the ownership voucher Field should be byte instead of string
3 participants
@gmacf @chuckx @melzhan