Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DNS name to certificate generator and regenerate. #81

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

gmacf
Copy link
Contributor

@gmacf gmacf commented Oct 24, 2023

The DNS name is required for the client to validate the certificate.

Also refactors generator to use os.WriteFile as suggested.

@gmacf gmacf requested a review from yvetteyuanw October 24, 2023 05:29
@gmacf gmacf linked an issue Oct 24, 2023 that may be closed by this pull request
@gmacf gmacf merged commit 1fe9249 into openconfig:main Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

testdata/generate.go consider using os.WriteFile instead
2 participants