-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a cycles.csv target which recomputes only if the inputs or the xdsl commit change #61
Conversation
Not sure why the CI is failing, isn't xdsl a submodule located at /src/xdsl for the CI also? |
having a look |
On second thought, here are some csvs generated, I think it's worth discussing committing them now |
|
Moreover, I can simplify the results collection if we keep them. |
I'll start work on this while waiting for others to chip in. |
ah nice if you feel like doing this that would be great. I think it's less of a priority than getting the other kernels in but I think it will let us iterate more quickly once we do have it |
I think meanwhile I'll merge it it's additive at the moment and lets me test the other branches more easily |
|
This is a step towards caching more of the traces being computed, I think it's a shame for us to wait for a long time to recompute things that don't change, hopefully by transitioning to a make-based system we'll spend a lot less time waiting for results.
This PR doesn't commit the csv files generated for me locally, but I think we should consider adding them, and changin the CI to only check that there is no work to be done when running
make results/combined.csv
on the server.