Provide SSR runtime APIs as global symbols #33
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing as obsolete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (stacked on top of #25) tries to address the issue of SSR symbols defined as
inlinein upstream's runtime, making them essentially not callable outside of C. This PR providesexterndeclarations and definitions, forcing the compiler to actually emit symbols in the resulting object.Note: the reason why SSR functions were either
inline-inlined or LTO-inlined is because performing actual function calls inside kernels skews cycle measurements by a significant amount (especially when dealing with hot loops with small trip count).