-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add scripts for results collection and plotting #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compor
requested review from
superlopuh,
nazavode,
AntonLydike and
JosseVanDelm
October 11, 2023 13:04
compor
changed the title
Christos/result scripts
Add scripts for results collection and plotting
Oct 11, 2023
superlopuh
reviewed
Oct 11, 2023
superlopuh
reviewed
Oct 11, 2023
Very nice! Could you please split this PR into two, one that collects jsons into a csv or maybe another json, and another that creates a plot? I'd rather stay in text land as long as possible. |
compor
force-pushed
the
christos/result-scripts
branch
from
October 17, 2023 09:18
bdc8ccf
to
a3a96cb
Compare
superlopuh
approved these changes
Oct 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ty
Opened #30 as this is going to be split in two. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is another step towards "one shot" Docker runs:
requirements.txt
file for both of the aboveThe idea is that one could potentially run one step without the other (e.g., tweak the plotting config without rerunning Verilator), but both could be used in an experiments run pipeline.
Next up is the Docker driver script.