Skip to content

tile-size-0-40-100-failure #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

EmilySillars
Copy link

  • Changing dispatch 9's tile size from 56x100 to 40x100 causes a build error.
  • This must be a bug, because 40x100 is smaller than 56x100, meaning it definitely fits in L1 (tile size is not too big).
  • Full build output attached: dispatch-9-build-error.txt

@superlopuh
Copy link
Contributor

If you look at the error, it's all in xDSL, not in Quidditch, so it's not really a bug related to L1 sizes. It seems like for some reason one of the kernels that shouldn't be compiled via xDSL, as we don't handle math.exp lowering, is still passed to it. Do you happen to know where the logic for this is?

@EmilySillars
Copy link
Author

  • No, that math.exp warning is always there. That does not cause the build to fail.
  • I just re-built successfully on the small-tile branch using tile size 0-56-100, and it builds fine. You will see that the math.exp warning remains: build-output-dispatch-9-0-56-100.txt
  • This bug is indeed related to tile sizes: when I change the tile size to 0-40-100, the build fails.
  • here is a diff of the two build outputs, one for tile size 56x100, and one for tile size 40x100:
    success_vs_failure.txt

@superlopuh
Copy link
Contributor

Oh I see! That's annoying that the compilation is noisy like that, feels like a bug to me TBH.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants