change codes for julia 1.0+ #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
very nice @leejm516 👍 - the tests pass locally. I will see what's up with the remaining issues. |
|
It seems that CI is running tests against Julia v0.6? Maybe travis needs to be fixed to run tests against Julia 1.0 instead? |
This was referenced Sep 4, 2019
Closed
|
Update: ✅ Gurobi and CPLEX tests pass. Following issues remain:
|
This reverts commit 7e6afa5.
|
Tests for PALM.jl run on Linux and macOS, but not on Windows. See issue #50. |
|
Apart from the 2 minor open issues, everything's looking sharp! Thanks @leejm516 👍 |
|
Great work @laurentheirendt and @leejm516! |
|
Can you tag a release? |
|
Not yet. Certain issues are still open that need fixing first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@laurentheirendt, here I do PR again from your last commit of the develop branch. Could you have a look?
Remaining issues:
distributedFBAwith the CPLEX solver raises an error during the test