Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check for nans in gsp capacities #171

Merged
merged 1 commit into from
Feb 1, 2025
Merged

check for nans in gsp capacities #171

merged 1 commit into from
Feb 1, 2025

Conversation

peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Feb 1, 2025

Pull Request

Description

Make sure there are no nans in the gsp capacites

This doesnt solve the underlying issue, but at least it will catch the problem

How Has This Been Tested?

CI tests

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

Copy link

@braddf braddf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sensible to me 👍

@peterdudfield peterdudfield merged commit 477017a into main Feb 1, 2025
3 checks passed
@peterdudfield peterdudfield deleted the issue/nan-capacity branch February 1, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants