Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused configs #355

Merged
merged 2 commits into from
Aug 9, 2024
Merged

Remove unused configs #355

merged 2 commits into from
Aug 9, 2024

Conversation

AUdaltsova
Copy link
Contributor

@AUdaltsova AUdaltsova commented Aug 9, 2024 •
edited
Loading

Pull Request

Description

Strips out get_center and data_source_which_defines_geospatial_locations arguments from configs and tests, as these are not implemented and never used.

Has a sister PR in pvnet that strips those parameters out of the only test they are present in.

Fixes #324

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@AUdaltsova AUdaltsova changed the title Rm unused configs Remove unused configs Aug 9, 2024
@AUdaltsova AUdaltsova mentioned this pull request Aug 9, 2024
Merged
5 tasks
@AUdaltsova AUdaltsova merged commit 23127ca into main Aug 9, 2024
5 checks passed
@AUdaltsova AUdaltsova deleted the rm-unused-configs branch August 9, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterdudfield peterdudfield peterdudfield approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove or implement unused parameters in ocf_datapipes/config/model.py
2 participants
@AUdaltsova @peterdudfield