change ml_id infills to zero from nan #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AUdaltsova
requested review from
Sukh-P and
dfulu
and removed request for
Sukh-P
dfulu
requested changes
Aug 7, 2024
Yeah good idea! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
When ml_id is not in metadata, we create a new column filled with
np.nan, which will later be infilled by zeroes over and over. This PR creates it as a column of -1 to signal that this is not a normal ml_idFixes #321
How Has This Been Tested?
Ran batch creation and later training with this change for windnet; change for pvnet is the same
Checklist: