Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reading from real DB #10

Merged
merged 4 commits into from
Feb 8, 2024
Merged

Reading from real DB #10

merged 4 commits into from
Feb 8, 2024

Conversation

confusedmatrix
Copy link
Contributor

@confusedmatrix confusedmatrix commented Feb 1, 2024 •
edited
Loading

Pull Request

Description

  • Pull real data from DB
  • Converted tests to pytest
  • Updated Containerfile

TODO

  • More robust tests
  • Test container locally

How Has This Been Tested?

  • Unit tests written for all client functions
  • Tested API run locally and within docker container attached to DB

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@confusedmatrix confusedmatrix mentioned this pull request Feb 1, 2024
Closed
6 tasks
This was linked to issues Feb 1, 2024
update API to read actual values #6
Closed
update API to read forecasted values #7
Closed
@confusedmatrix confusedmatrix marked this pull request as ready for review February 7, 2024 14:38
@confusedmatrix confusedmatrix requested review from devsjc and peterdudfield and removed request for devsjc February 7, 2024 14:38
peterdudfield
peterdudfield reviewed Feb 8, 2024
View reviewed changes
src/india_api/internal/inputs/indiadb/client.py Outdated
return ["ruvnl"]


def _getWindow() -> tuple[dt.datetime, dt.datetime]:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is duplicated from a different model, should we refactor tor remove duplciate code. Happy if its put as an issue and dealt with later

peterdudfield
peterdudfield approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@peterdudfield peterdudfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment, totally up to you.

And running it locally would be great, just to check it works e.t.c

@confusedmatrix
Copy link
Contributor Author

One small comment, totally up to you.

And running it locally would be great, just to check it works e.t.c

Tested running locally against live DB and all working well!

@confusedmatrix confusedmatrix merged commit ddf0772 into main Feb 8, 2024
6 checks passed
@confusedmatrix confusedmatrix deleted the chris/realdb branch February 8, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterdudfield peterdudfield peterdudfield approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update API to read forecasted values update API to read actual values
2 participants
@confusedmatrix @peterdudfield