Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup fix #778

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Cleanup fix #778

merged 2 commits into from
Jan 17, 2025

Conversation

at88mph
Copy link
Member

@at88mph at88mph commented Jan 17, 2025

No description provided.

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 20.60%. Comparing base (f25d5e6) to head (6d69811).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #778   +/-   ##
=========================================
  Coverage     20.60%   20.60%           
  Complexity      118      118           
=========================================
  Files            23       23           
  Lines          1980     1980           
  Branches        270      270           
=========================================
  Hits            408      408           
  Misses         1521     1521           
  Partials         51       51           
Flag Coverage Δ
skaha-unittests-coverage 20.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rptaylor
Copy link
Contributor

This also fixes #777

Copy link
Collaborator

@kcasteels kcasteels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@at88mph at88mph merged commit 5ca7890 into opencadc:main Jan 17, 2025
9 checks passed
@at88mph at88mph deleted the cleanup-fix branch January 17, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants