-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI/CD Improvements #741
CI/CD Improvements #741
Conversation
…rather than dir:skaha this is needed for ratchetFrom configuration for spotless which requires git history
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #741 +/- ##
=========================================
Coverage 18.61% 18.61%
Complexity 102 102
=========================================
Files 22 22
Lines 1961 1961
Branches 270 270
=========================================
Hits 365 365
Misses 1544 1544
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…leaking of secrets/passwords and errors in shell scripts
…buting guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Be aware that we also have CODE_OF_CONDUCT
and CONTRIBUTING
documents in our .github repository. I'll approve this though.
This pull request includes several changes aimed at improving the CI/CD workflows, removing outdated integration test configurations, and updating pre-commit configurations. Here are the most important changes:
CI/CD Workflow Improvements:
context
indocker/build-push-action
to use the root directory instead ofskaha/
in.github/workflows/cd.edge.build.yml
and.github/workflows/cd.release.build.yml
. [1] [2]cosign sign
command to use the digest format${{ steps.build.outputs.digest }}
in.github/workflows/cd.edge.build.yml
and.github/workflows/cd.release.build.yml
. [1] [2]New CI Workflow:
ci.commit.check.yml
to enforce commit message conventions and branch naming conventions.Pre-Commit Configuration Updates:
deployment/
directory from pre-commit checks in.pre-commit-config.yaml
.skaha/src/test/resources/
directory from YAML syntax checks in.pre-commit-config.yaml
.Removal of Integration Test Configurations:
integration-test
directory, including theREADME.md
,build.gradle
, and various configuration files, to clean up outdated test setups. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]