Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI/CD Improvements #741

Merged
merged 17 commits into from
Nov 26, 2024
Merged

CI/CD Improvements #741

merged 17 commits into from
Nov 26, 2024

Conversation

shinybrar
Copy link
Collaborator

This pull request includes several changes aimed at improving the CI/CD workflows, removing outdated integration test configurations, and updating pre-commit configurations. Here are the most important changes:

CI/CD Workflow Improvements:

  • Modified the context in docker/build-push-action to use the root directory instead of skaha/ in .github/workflows/cd.edge.build.yml and .github/workflows/cd.release.build.yml. [1] [2]
  • Updated the cosign sign command to use the digest format ${{ steps.build.outputs.digest }} in .github/workflows/cd.edge.build.yml and .github/workflows/cd.release.build.yml. [1] [2]

New CI Workflow:

  • Added a new CI workflow ci.commit.check.yml to enforce commit message conventions and branch naming conventions.

Pre-Commit Configuration Updates:

  • Excluded the deployment/ directory from pre-commit checks in .pre-commit-config.yaml.
  • Excluded the skaha/src/test/resources/ directory from YAML syntax checks in .pre-commit-config.yaml.

Removal of Integration Test Configurations:

  • Removed the integration-test directory, including the README.md, build.gradle, and various configuration files, to clean up outdated test setups. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 18.61%. Comparing base (c680510) to head (6e400f8).
Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #741   +/-   ##
=========================================
  Coverage     18.61%   18.61%           
  Complexity      102      102           
=========================================
  Files            22       22           
  Lines          1961     1961           
  Branches        270      270           
=========================================
  Hits            365      365           
  Misses         1544     1544           
  Partials         52       52           
Flag Coverage Δ
skaha-unittests-coverage 18.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shinybrar shinybrar requested a review from at88mph November 25, 2024 23:17
skaha/README.md Outdated Show resolved Hide resolved
.github/dependabot.yml Show resolved Hide resolved
Copy link
Member

@at88mph at88mph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be aware that we also have CODE_OF_CONDUCT and CONTRIBUTING documents in our .github repository. I'll approve this though.

@at88mph at88mph merged commit 7f2d086 into opencadc:main Nov 26, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants