Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated int test README file #154
base: main
Are you sure you want to change the base?
Updated int test README file #154
Changes from 6 commits
f5bdaf3
e5be489
847e63a
0e37f03
e7cd303
6df5f1a
e720b6a
38a8385
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
technically, one can use
icewind
to create the caom2 tables and add some content OR deploytorkeep
to just create the tablesI do not recall if the tests will all pass when the tables are empty, but they should. The tests would not hit all possible code paths, but that's going to be true with real content and would not be completely thorough unless we specify some specific test content (a handful of observations with all possible fields filled in).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
testing should always use pool size of 1 for all pools
I never put the PG port number in JDBC URLs since we always run on the default port. Better to omit.