Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task3：xiangnuans #753

Merged
merged 13 commits into from
Jul 4, 2024
Merged

Task3：xiangnuans #753

merged 13 commits into from
Jul 4, 2024

Conversation

xiangnuans
Copy link
Collaborator

@xiangnuans xiangnuans commented Jun 18, 2024 •
edited
Loading

linghuccc
linghuccc requested changes Jul 1, 2024
View reviewed changes
Copy link
Collaborator

@linghuccc linghuccc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

task3 只需要提交最主要的 3 份合约文件和上架NFT、购买NFT的交易哈希，请不要提交其他无关文件，谢谢

@xiangnuans
Copy link
Collaborator Author

我把编译文件删除了，但目前是保留了脚本和初始化项目的文件，再看看哈

@xiangnuans xiangnuans requested a review from linghuccc July 4, 2024 06:15
linghuccc
linghuccc requested changes Jul 4, 2024
View reviewed changes
Copy link
Collaborator

@linghuccc linghuccc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. 请提供上架 NFT 哈希；
  2. 买家，卖家请使用不同地址；
  3. 购买哈希显示的编程实现，与代码不符。

请修改，谢谢

@xiangnuans
Copy link
Collaborator Author

1、3两点，pr提交里已经说明清楚了
2. 根据作业要求，并没有说不让用同一个账户，所以是符合作也要求的
image

@xiangnuans xiangnuans merged commit 5e1d5e4 into openbuildxyz:main Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linghuccc linghuccc linghuccc requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xiangnuans @linghuccc