Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Update JSON structure; keep all fields #61

Merged
merged 2 commits into from
Mar 9, 2025
Merged

[Fix] Update JSON structure; keep all fields #61

merged 2 commits into from
Mar 9, 2025

Conversation

chrisjm
Copy link
Collaborator

@chrisjm chrisjm commented Mar 9, 2025 •
edited
Loading

📃 Description

Fixing the JSON structure to include everything to be in parity with the existing API and fix tests.

NOTE: I notice that the Lat/Long are numeric in the new API and strings in the original. It should have always been numeric. :)

Remove

  • Unnecessary State Filter Test re: abbreviations that isn't in the original API

📷 Screenshots

CleanShot 2025-03-08 at 20 17 35@2x CleanShot 2025-03-08 at 20 08 48@2x CleanShot 2025-03-08 at 20 09 03@2x

@chrisjm chrisjm requested a review from alexjustesen as a code owner March 9, 2025 04:12
@chrisjm chrisjm added the 🐛 bug Something isn't working label Mar 9, 2025
@alexjustesen alexjustesen merged commit 7ef83f5 into main Mar 9, 2025
2 checks passed
@alexjustesen alexjustesen deleted the fix-json-structure branch March 9, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexjustesen alexjustesen alexjustesen approved these changes

Assignees
No one assigned
Labels
🐛 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrisjm @alexjustesen