Add nvme manager support #1
Conversation
phosphor-nvme is the nvme manager service maintains for NVMe drive information update and related notification processing service. Signed-off-by: Tony Lee <[email protected]> Change-Id: I32678dc4cf246d67b3bdc3329b5c3f70901f66c2
| #define MAX_I2C_BUS 30 | ||
| #define MONITOR_INTERVAL_SENCODS 1 | ||
| #define NVME_SSD_SLAVE_ADDRESS 0x6a | ||
| #define GPIO_BASE_PATH "/sys/class/gpio/gpio" |
There was a problem hiding this comment.
Please use the gpioplus library instead of accessing the GPIOs through sysfs. It will simplify some of the error handling and be easier to maintain.
| std::string obj_path; | ||
| obj_path = ledPath; | ||
|
|
||
| try{ |
There was a problem hiding this comment.
Run this through clang-format to make the coding style consistent. You can reuse the .clang-format config file from another OpenBMC repo.
|
|
||
| }catch (const sdbusplus::exception::SdBusError& ex) | ||
| { | ||
| std::cerr << "Call method fail: set fault LED Aasserted. ERROR = " << ex.what() << std::endl; |
There was a problem hiding this comment.
Use phosphor-logging instead of std::cerr
| @@ -0,0 +1,514 @@ | |||
| /* | |||
| i2c-dev.h - i2c-bus driver, char device interface | |||
There was a problem hiding this comment.
Was this file newly written or copied from somewhere? The copyright header doesn't seem to match
|
Since Gerrit synchronization is working again, let's continue this on Gerrit instead. |
Thanks for your advice above, we'll continue this on Gerrit instead. |
phosphor-nvme is the nvme manager service maintains
for NVMe drive information update and related notification
processing service.
Signed-off-by: Tony Lee [email protected]
Change-Id: I32678dc4cf246d67b3bdc3329b5c3f70901f66c2