Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hwmontempsensor doesn't notice card removals #11

Open
spinler opened this issue Mar 5, 2021 · 0 comments
Open

hwmontempsensor doesn't notice card removals #11

spinler opened this issue Mar 5, 2021 · 0 comments

Comments

@spinler
Copy link
Contributor

spinler commented Mar 5, 2021

It isn't watching for an InterfacesRemoved signal from entity-manager, so it doesn't realize the device went away and still tries to read it anyway, so it treats it like an error.

Ideally, it should remove the sensor from D-Bus in that case as discussed on discord.

This actually goes for every application in the same repo, since I don't see any InterfacesRemoved watches at all, but as my company only uses hwmontempsensor at the moment it's the only one I can fix, and the code between them isn't common enough to fix it all in one place.

I plan on making this change. Just opening an issue for general awareness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant