Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for FRU removal in dbus-sensors/hwmontempsensor #2991

Closed
spinler opened this issue Mar 5, 2021 · 1 comment
Closed

Support for FRU removal in dbus-sensors/hwmontempsensor #2991

spinler opened this issue Mar 5, 2021 · 1 comment
Assignees
Milestone

Comments

@spinler
Copy link

spinler commented Mar 5, 2021

Need a change so that the sensor is removed from D-Bus when a cable card is removed, otherwise it will be unrecognizable from a regular communications error.

See openbmc/dbus-sensors#11 for details. Opening here for tracking purposes.

Note that right now nothing would clear the inventory when a card is removed, so entity-manager would never send an InterfacesRemoved for hwmontempsensor to find. Another option is to put GPIO support into hwmontempsensor, though we'd have to be careful about hwmontempsensor trying to access a chip before VPD sets the access GPIO, which sets the I2C address for the TMP435/TMP275. Could then either get a read for or a read of another device, depending on what the defaults are.

@spinler spinler self-assigned this Mar 5, 2021
@rfrandse rfrandse added this to the A.1.212 milestone Mar 6, 2021
@spinler
Copy link
Author

spinler commented May 5, 2021

We're not going to go this direction, instead hwmontempsensor will do all the work of knowing when power is on. Closing.

@spinler spinler closed this as completed May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants