Skip to content

Bump curlimages/curl from 8.13.0 to 8.14.1 #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Bump curlimages/curl from 8.13.0 to 8.14.1 #113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM curlimages/curl:8.13.0 AS builder
FROM curlimages/curl:8.14.1 AS builder

# see https://github.com/openbikesensor/OpenBikeSensorFirmware/releases
ARG FIRMWARE_VERSION=0.21.929
Expand All @@ -15,7 +15,7 @@
unzip obs-v${FIRMWARE_VERSION}-initial-flash.zip && \
rm obs-v${FIRMWARE_VERSION}-initial-flash.zip

COPY --chown=curl_user ./public-html/ ./

Check warning on line 18 in Dockerfile

View workflow job for this annotation

GitHub Actions / build-and-push-image

[LOW] Chown Flag Exists 

It is considered a best practice for every executable in a container to be owned by the root user even if it is executed by a non-root user, only execution permissions are required on the file, not ownership
RUN sed -i "s/FIRMWARE_VERSION/${FIRMWARE_VERSION}/g" /tmp/obs/index.html && \
sed -i "s/FIRMWARE_VERSION/${FIRMWARE_VERSION}/g" /tmp/obs/manifest.json && \
cp /tmp/obs/manifest.json /tmp/obs/manifest-obs-${FIRMWARE_VERSION}.json && \
Expand All @@ -42,7 +42,7 @@
# see at https://github.com/esphome/esp-web-tools/releases
ARG ESP_WEB_TOOLS_VERSION=10.1.0

RUN export DEBIAN_FRONTEND=noninteractive && \

Check warning on line 45 in Dockerfile

View workflow job for this annotation

GitHub Actions / build-and-push-image

[INFO] Apt Get Install Lists Were Not Deleted 

After using apt-get install, it is needed to delete apt-get lists

Check warning on line 45 in Dockerfile

View workflow job for this annotation

GitHub Actions / build-and-push-image

[INFO] APT-GET Not Avoiding Additional Packages 

Check if any apt-get installs don't use '--no-install-recommends' flag to avoid installing additional packages.

Check warning on line 45 in Dockerfile

View workflow job for this annotation

GitHub Actions / build-and-push-image

[MEDIUM] Apt Get Install Pin Version Not Defined 

When installing a package, its pin version should be defined
apt-get update -qq && \
apt-get install -y -qq jq && \
npm install -g [email protected]
Expand All @@ -59,12 +59,12 @@
chmod -R a=rX /tmp/esp-web-tool/dist


FROM httpd:2.4-alpine

Check warning on line 62 in Dockerfile

View workflow job for this annotation

GitHub Actions / build-and-push-image

[LOW] Healthcheck Instruction Missing 

Ensure that HEALTHCHECK is being used. The HEALTHCHECK instruction tells Docker how to test a container to check that it is still working

Check warning on line 62 in Dockerfile

View workflow job for this annotation

GitHub Actions / build-and-push-image

[HIGH] Missing User Instruction 

A user should be specified in the dockerfile, otherwise the image will run as root

LABEL version="${FIRMWARE_VERSION}" \

Check warning on line 64 in Dockerfile

View workflow job for this annotation

GitHub Actions / build-and-push-image

Variables should be defined before their use 

UndefinedVar: Usage of undefined variable '$FIRMWARE_VERSION'
More info: https://docs.docker.com/go/dockerfile/rule/undefined-var/
description="OpenBikeSensor Firmware with ESP Web Tools" \
maintainer="[email protected]"

COPY --chown=nobody:nogroup --from=builder /tmp/obs/ /usr/local/apache2/htdocs/

Check warning on line 68 in Dockerfile

View workflow job for this annotation

GitHub Actions / build-and-push-image

[LOW] Chown Flag Exists 

It is considered a best practice for every executable in a container to be owned by the root user even if it is executed by a non-root user, only execution permissions are required on the file, not ownership
COPY --chown=nobody:nogroup --from=nodebuilder /tmp/esp-web-tool/dist/web/ /usr/local/apache2/htdocs/esp-web-tools

Check warning on line 69 in Dockerfile

View workflow job for this annotation

GitHub Actions / build-and-push-image

[LOW] Chown Flag Exists 

It is considered a best practice for every executable in a container to be owned by the root user even if it is executed by a non-root user, only execution permissions are required on the file, not ownership

Loading