Install fish shell in a different way

This way works with the container being built for a different platform than it's running on
openaustralia · Nov 28, 2023 · 6f5fa31 · 6f5fa31
1 parent 4da575c
commit 6f5fa31
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json
@@ -17,11 +17,11 @@
 	// The optional 'workspaceFolder' property is the path VS Code should open by default when
 	// connected. This is typically a file mount in .devcontainer/docker-compose.yml
 	"workspaceFolder": "/app",
-	"features": {
-		"ghcr.io/meaningful-ooo/devcontainer-features/fish:1": {}
-	},
 	"customizations": {
 		"vscode": {
+			"settings": {
+				"terminal.integrated.defaultProfile.linux": "fish"
+			},
 			"extensions": [
 				"wingrunr21.vscode-ruby",
 				"karunamurti.haml",

diff --git a/Dockerfile b/Dockerfile
@@ -43,6 +43,9 @@ RUN apt-get install -y nodejs
 # Install firefox for running some integration tests
 RUN apt-get update; apt-get install -y firefox-esr
 
+# Install the fish shell
+RUN apt-get install -y fish
+
 USER deploy
 
 COPY --chown=deploy:deploy Gemfile /app/Gemfile