-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: Typescript migration #1472
base: dev
Are you sure you want to change the base?
Conversation
51cbcc9
to
81af6b1
Compare
About the test error:
cat stdout_output | jq ".CSFGlucoseData | first" | grep -q null || fail_test "oref0-autotune-prep with carbhistory didn't contain expected CSF Glucose Data" I guess the problem is about a bug on original meal dedupe in meal/history.
that set Debugging the original code, there are two duplicates meal entries with the same timestamp. |
`generate` functions must be the entry-points for unknown inputs. Inputs must be validated and eventually transformed.
Work In Progress.
This could be the 0.8 release.
Currently, developing on the oref0 repository is very hard for the open source community.
It's hard to understand what variables contain, and there are a lot of javascript errors (undeclared variables, multiple types for the same variables, etc...).
This is the first draft where I've refactored a lot of
lib/
scripts in Typescript. This will allow to have types and interfaces for objects, with the opportunity to document them.Tests
All tests passes, except for the
test-autotune-prep
intests/command-behavior.tests.sh
. Honestly I can't understand why there is a check for anull
value:Changes
Some of changes are:
moment
,moment-timezone
andlodash
from dependencies: smaller bundles for apps like (iAPS). iAPS is 50-75% fasterCONTRIBUTING.md
): just open the project in VSCode, and you will have your development environment without install dependencies in your systemCONTRIBUTING.md
Future changes
any
where not completely migrated)If you want to contribute, please add a PR to my repository.