Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

達成基準3.1.5にSpindleのUIラベリングルールセクションを追加 #414

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

itsminadesu
Copy link
Contributor

@itsminadesu itsminadesu commented Sep 25, 2023

fix #403

概要

3.1.5 難しい文章表現を避けるテスト・チェック方法にSpindleのUIラベリングルールセクションを追加しました

関連リンク

3.1.5 難しい文章表現を避けるに、SpindleのUIラベリングの紹介を掲載する

確認項目

Pull Requestを出す前に確認しましょう。

  • コミットは適切にまとめられているか
  • Pull Requestの概要を適切に書いたか
  • レビュワーの指定をしているか
  • textlintを実行しエラーが出ていないか
  • [-] Accessibility

レビュー完了希望日

9/27(水)

@reg-suit
Copy link

reg-suit bot commented Sep 25, 2023

reg-suit detected visual differences.

Check this report, and review them.

🔴

🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵

What do the circles mean? The number of circles represent the number of changed images.
🔴 : Changed items, ⚪ : New items, ⚫ : Deleted items, and 🔵 Passed items

How can I change the check status? If reviewers approve this PR, the reg context status will be green automatically.

@github-actions
Copy link

github-actions bot commented Sep 25, 2023

Visit the preview URL for this PR (updated for commit daf4156):

https://ameba-a11y-guidelines--pr414-feature-3-1-5-u4pagzz4.web.app

(expires Mon, 09 Oct 2023 08:59:25 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: b5ed0ee52825c395d695adc443890c0775e604f1

src/3/1/5.md Show resolved Hide resolved
Copy link
Contributor

@tokimari tokimari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

エンジニアを褒めるネコ:定時あがり

@itsminadesu itsminadesu merged commit b6a515b into master Oct 2, 2023
6 checks passed
@itsminadesu itsminadesu deleted the feature/3-1-5 branch October 2, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.1.5 難しい文章表現を避けるに、SpindleのUIラベリングの紹介を掲載する
3 participants