fix: set max capacity for ssestream decoder bufio scanner #373
+11
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecrubin
commented
Apr 15, 2025
| @@ -14,6 +14,11 @@ import ( | |||
| "github.com/tidwall/gjson" | |||
| ) | |||
|
|
|||
| const ( | |||
| // ScannerMaxCapacity is the maximum capacity of the scanner buffer used in the decoder. | |||
| DecoderScannerMaxCapacity = 512 * 1024 // 512 KiB | |||
There was a problem hiding this comment.
Not sure what the right value to set here is, hopefully someone from the OpenAI team can tell us what the max size needs to be, but I didn't notice any token too long errors after increasing the capacity to this.
|
Thanks @alecrubin, we'll get this fix in. Unfortunately it needs to be implemented in the code-generator, so this PR directly be merged. |
Great, thanks @jacobzim-stl! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Override the default bufio.Scanner max capacity in the ssestream.Decoder.
Fixes #368