Adding ID support for FinishedChatCompletionToolCall #253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds ID field support to the FinishedChatCompletionToolCall struct, enabling it to capture and return the unique identifier for tool calls. This ensures tool calls can be accurately tracked and referenced in streaming responses.
Changes
Added ID field to FinishedChatCompletionToolCall struct
Refactored JustFinishedToolCall() method to properly retrieve and return tool call IDs
Updated test cases to validate ID field handling
Impact
This change allows API clients to access complete tool call metadata, particularly in streaming scenarios, enabling reliable tracking and management of tool call lifecycles.