Adding extra_headers parameters to ModelSettings #550
+7
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rm-openai It doesn't look like I have the ability to request reviews. Is there a process I should follow? |
jonnyk20
force-pushed
the
add_extra_headers_parameters
branch
from
0e46448 to
025d58e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the possibility to pass
extra_headerswhen sending a request.I used the same implementation as was recently used for
extra_bodyandextra_queryin #500In this implementation I added the attributes to ModelSettings as suggested here
https://github.com/openai/openai-agents-python/issues/487 .
I'll be happy to add some tests if you have any suggestions.