fix: prevent ContextVar reset error in async streaming context. #516
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a runtime error caused by an unexpected
reset_current
keyword argument passed toTrace.finish()
within theRunResultStreaming.stream_events()
method.What was the issue?
Currently,
stream_events()
calls:refer #515
Solution
Wrap the .finish(reset_current=True) call in a try/except block to fallback to a safe reset mode:
🧪 Testing
Tested with a minimal FastAPI + StreamingResponse setup. After this patch:
📦 Affected file
openai-agents-python\src\agents\result.py
💬 Related Issue
This PR resolves the bug described in the issue: #515