fix(cli): double-Esc cancels current prompt, not history (#784) #785
+11
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #784
What
This change makes “Esc Esc” only cancel the in-flight generation, instead of wiping out the entire chat history.
escCount
inTextBuffer
to track consecutive Escape presses.onCancelCurrent
callback that consumers (e.g. the CLI session) can hook to abort only the current generation.handleInput
so:Esc
incrementsescCount
and returnsfalse
(no re-render).Esc
resetsescCount
, invokesonCancelCurrent
, and returnstrue
to trigger a re-render.escCount
to zero.text-buffer.test.ts
covering:Esc
does not cancel and does not re-render.Esc
callsonCancelCurrent
exactly once and requests a re-render.Esc
presses reset the counter.How to test