fix(run_in_container): drop hardcoded --full-auto flag #783
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
braun-viathan
force-pushed
the
fix/run-in-container-no-full-auto
branch
from
36634fe to
39ff37a
Compare
4 tasks
What: This commit removes the hardcoded `--full-auto` flag from the `run_in_container.sh` script. Why: The `--full-auto` flag was hardcoded in the `run_in_container.sh` script, which is used to run Codex in a containerized environment. This flag was causing issues for users who wanted to run Codex with different approval modes or configurations. How: By removing the hardcoded flag, users can now specify their own approval modes and configurations when running Codex in a container. This change aligns the behavior of the containerized version of Codex with the behavior of the non-containerized version, allowing for greater flexibility and customization. Refs openai#781 - openai#781
braun-viathan
force-pushed
the
fix/run-in-container-no-full-auto
branch
from
39ff37a to
8df54a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In run_in_container.sh Codex was started with hardcoded --full-Auto which makes it impossible for users to supply other
--approval-mode parameters.
Removing the flag lets Codex in a container respect CLI options on Linux the same way it does without the container.
Refs #781
PR-Checklist: