conformance-profiles: Database table and worker to process data #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odscjames
force-pushed
the
33-data-profiles-in-database
branch
from
3de9465
to
24190ea
Compare
michaelwood
reviewed
Jul 22, 2020
| 'ON normalised_data_profile_results.normalised_data_id = normalised_data.id AND normalised_data_profile_results.profile_name=$1 '+ | ||
| 'WHERE normalised_data_profile_results.normalised_data_id IS NULL AND normalised_data.data_deleted=FALSE '+ | ||
| 'ORDER BY normalised_data.updated_at ASC LIMIT 10'; | ||
|
|
There was a problem hiding this comment.
You can use back ticks ` for multi line strings rather than concatenation at run time.
michaelwood
approved these changes
Jul 22, 2020
| 'ORDER BY normalised_data.updated_at ASC LIMIT 10'; | ||
|
|
||
| while(true) { | ||
|
|
There was a problem hiding this comment.
I usually try to make sure there is some kind of safety catch in a while true, might be worth adding if there is way to do that
There was a problem hiding this comment.
Point - The catch() block should have break in it - that will apply in several places tho so I'll do that in another P.R.
|
I'll merge as this blocks some other things then do the readme straight away - forgot that, sorry. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#33