spider: Write errors to database #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odscjames
force-pushed
the
3-spider-errors
branch
from
3fcd141
to
354e7ac
Compare
michaelwood
reviewed
Jun 25, 2020
| url TEXT NOT NULL, | ||
| error TEXT NOT NULL, | ||
| error_at TIMESTAMP WITHOUT TIME ZONE NOT NULL default (now() at time zone 'utc'), | ||
| found_via JSON NOT NULL |
There was a problem hiding this comment.
Wouldn't we want a fk here to the publisher?
There was a problem hiding this comment.
Because it might be an error at the level of getting a data catalogue, and at that point there is no publisher. Also even an error when parsing a publisher would result in no publisher being written.
michaelwood
approved these changes
Jun 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3