fix modules/suse_apache missing apache2ctl #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The suse_apache module is checking if `apache2ctl` is present at the minion. This check fails on current openSUSE Factory because apache2ctl was renamed to apachectl. `apache2ctl` isn't execute in the suse_apache module at all. With this patch the suse_apache module checks for the two really used excecutables (`a2enmod`/`a2dismod`)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The suse_apache module is checking if
apache2ctlis present at the minion. This check fails on current openSUSE Factory because apache2ctl was renamed to apachectl.apache2ctlisn't execute in the suse_apache module at all.What does this PR do?
With this patch the suse_apache module checks for the two really used excecutables (
a2enmod/a2dismod)What issues does this PR fix or reference?
Fixes: NONE
Previous Behavior
enabling/disabling modules failed
Commits signed with GPG?
Yes