Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generating from archive option, fix exceptions, caused by multiline content in rpm spec files, remove shebangs, fix missing provides_extra field, fix username empty string, add maintainer option, add --local and --localfile in show subcommand, make name attribute optional if --local or --localfile field is provided #217

Closed
wants to merge 3 commits into from

Conversation

huakim
Copy link
Contributor

@huakim huakim commented Jan 13, 2025

No description provided.

u added 2 commits January 13, 2025 09:50
…ne content in rpm spec files, remove shebangs, fix missing provides_extra field
@huakim huakim changed the title Add generating from archive option, fix exceptions, caused by multiline content in rpm spec files, remove shebangs, fix missing provides_extra field Add generating from archive option, fix exceptions, caused by multiline content in rpm spec files, remove shebangs, fix missing provides_extra field, fix username empty string, add maintainer option Jan 13, 2025
@mcepl
Copy link
Contributor

mcepl commented Jan 14, 2025

Note: you don’t have to close/reopen-new-PR every time you make a change to it. Just push a new commit to your branch, and GitHub will automatically update the pull request.

Also, could you, please, edit the description of this pull request and describe exactly what is the goal of this pull request, what is being changed, and which issues are resolved by it? It is crazy that we have to disassemble your intent by deciphering your code and trying to divine your intent from it.

Thank you for your effort!

@huakim
Copy link
Contributor Author

huakim commented Jan 15, 2025

Note: you don’t have to close/reopen-new-PR every time you make a change to it. Just push a new commit to your branch, and GitHub will automatically update the pull request.

Also, could you, please, edit the description of this pull request and describe exactly what is the goal of this pull request, what is being changed, and which issues are resolved by it? It is crazy that we have to disassemble your intent by deciphering your code and trying to divine your intent from it.

Thank you for your effort!

i'm too lazy for giving description of the pull request, and the goal was simply make tool works as it should, because at the current state tool is buggy, for example, the Maintainer field is empty when generating sources for Debian, or, some tags on RPM based sources, generated by tool, contains multiple lines

…ptional if --local or --localfile field is provided
@huakim huakim changed the title Add generating from archive option, fix exceptions, caused by multiline content in rpm spec files, remove shebangs, fix missing provides_extra field, fix username empty string, add maintainer option Add generating from archive option, fix exceptions, caused by multiline content in rpm spec files, remove shebangs, fix missing provides_extra field, fix username empty string, add maintainer option, add --local and --localfile in show subcommand, make name attribute optional if --local or --localfile field is provided Jan 15, 2025
@mcepl
Copy link
Contributor

mcepl commented Jan 15, 2025 via email

@huakim
Copy link
Contributor Author

huakim commented Jan 16, 2025

On Wed Jan 15, 2025 at 5:36 AM CET, huakim wrote: i'm too lazy for giving description of the pull request, and the goal was simply make tool works as it should
Right, so I was trying to be nice. Next time, there will be PR without description and reference to the ticket describing the issue such PR solves, it will be closed without reading.

Next time I will not open any PR

@huakim huakim closed this Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants