Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ability to build from local PKG-INFO file #185

Closed
wants to merge 15 commits into from
Closed

add ability to build from local PKG-INFO file #185

wants to merge 15 commits into from

Conversation

huakim
Copy link
Contributor

@huakim huakim commented Mar 15, 2024

No description provided.

danigm and others added 15 commits July 19, 2023 14:11
This patch uses build.project_wheel_metadata to extract more metadata
when it's not using setuptools and the metaextract package is not
useful.

This patch also includes some support for detecting scripts and test
dependencies for projects using poetry.

See ##177
 Please enter a commit message to explain why this merge is necessary,
 especially if it merges an updated upstream into a topic branch.

 Lines starting with '#' will be ignored, and an empty message aborts
 the commit.
@huakim huakim changed the title update add ability to build from local PKG-INFO file Mar 15, 2024
Copy link
Contributor

@mcepl mcepl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before I will be even looking at diff, could I ask for git rebase -i and rearranging commits to some meaningful units with proper commit messages?

https://who-t.blogspot.com/2009/12/on-commit-messages.html

@huakim
Copy link
Contributor Author

huakim commented Mar 15, 2024

Before I will be even looking at diff, could I ask for git rebase -i and rearranging commits to some meaningful units with proper commit messages?

https://who-t.blogspot.com/2009/12/on-commit-messages.html

I can, but lasy, code just work, and there isn't much changes done, just added two functions 'pypi_text_file' and 'pypi_json_file', also added --local, --localfile and --source-extension for generate subcommand. The --local flag indicates, that py2pack should fetch data from local file such as '{name}.egg-info/PKG-INFO' by default, --localfile indicates direct path to the local file. --source-extension is extension for source, if no source url is provided, by default it takes value '.zip'. Also, i merged commits from danigm user (#178), who did patch for using build.project_wheel_metadata to extract more metadata when it's not using setuptools and the metaextract package is not useful. There changes provided as is, with no any responsibilities, just for meself

@mcepl
Copy link
Contributor

mcepl commented Mar 15, 2024

just for meself

If you made changes just for yourself, then I don’t know why you submitted it here.

@mcepl mcepl closed this Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants