Introduce build --checks parameter #1600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmach
reviewed
Jul 11, 2024
osc/commandline.py
Outdated
| @@ -7170,6 +7170,8 @@ def parse_repoarchdescr(self, args, noinit=False, alternative_project=None, igno | |||
| help='Copy overlay filesystem to buildroot after installing all RPMs .') | |||
| @cmdln.option('--noinit', '--no-init', action='store_true', | |||
| help='Skip initialization of build root and start with build immediately.') | |||
| @cmdln.option('--checks', action='store_true', | |||
| help='Explicit run checks, if disabled in build config') | |||
There was a problem hiding this comment.
Rephrase to Force running checks, even if disabled in build config ?
There was a problem hiding this comment.
maybe call it --force-checks then even?
There was a problem hiding this comment.
It seems it's not forcing, it's only overriding a value from the commandline.
Another option for the help text might be: Run checks even if disabled in the build config
There was a problem hiding this comment.
adapted the message.
@dirkmueller it is not really forceing, it is usually anyway the default most of the time. However, I like to keep it in sync with build script parameter and it fit's better there this way.
Added in build script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added in build script
Depends on openSUSE/obs-build#1013