Reduce number of Clang warnings #607
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlandres
requested changes
Jan 28, 2025
There was a problem hiding this comment.
No. Please leave my switch untouched.
There was a problem hiding this comment.
- Is it okay that I replace the macro
RETURN_IFby directifs withstd::string::compareandreturns? - Should I replace the inside the macro
RETURN_IFthe::strcmpbystd::string::compare? - Should I leave the whole
MediaPriority.ccas it is, even if subjectively it is more difficult to maintain that it has to be?
There was a problem hiding this comment.
I went with 1. and removed the macro RETURN_IF but preserved the switch.
gruenich
force-pushed
the
feature/clang-warnings
branch
2 times, most recently
from
f4b7d9b to
5d026c4
Compare
Found by Clang (Winconsistent-missing-override)
Found by Clang (Wunused-private-field).
Found by Clang (Wunqualified-std-cast-call).
Found by Clang (Wunused-lambda-capture).
Avoids use of C macro that is discouraged by C++ Core gGidlines. Performance should be not crucial in this case. Fixes a warning found by Clang (Wstring-plus-int).
gruenich
force-pushed
the
feature/clang-warnings
branch
from
5d026c4 to
25f5528
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some are only part of
-Wallor-Wpedantic.MediaPriority got a major rewrite to use C++ instead of a clever switch statement that is difficult to understand.