fix: added translation changes #1939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PC-11-00
requested review from
josehernandezfintecheandomx and
bharathcgowda
|
@adamsaghy could you please help us in reviwing this PR? |
|
@PC-11-00 @bharathcgowda I see no other changes but code format changes and extra translations. Is there anything i am missing? |
|
No @adamsaghy, only translations changes |
Would you be so kind to rename the PR title, PR description and commit message accordingly, please? It is pretty misleading now... |
PC-11-00
changed the title
|
@adamsaghy yeah okay, actually I was working on this(maker-checker) issue, and by mistake I forgot to change the name sorry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now we can see the Client Approval, actually translation spelling was wrong so Html file was not loading and added few more translation changes
Related issues and discussion
Screenshots, if any
i35.mov
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
If you have multiple commits please combine them into one commit by squashing them.
Read and understood the contribution guidelines at
web-app/.github/CONTRIBUTING.md.