fix: now we can create standing instruction by using both destinantion #1936
Conversation
| @@ -58,6 +58,10 @@ export class CreateStandingInstructionsComponent implements OnInit { | |||
| accountTypeId: any; | |||
| /** Office Id */ | |||
| officeId: any; | |||
| /** ToOffice Id Boolean for disabling the officeId formControl */ | |||
| ToOfficeId: any; | |||
There was a problem hiding this comment.
I dont really understand what is the purpose of these fields.
| this.createStandingInstructionsForm.controls['toOfficeId'].disable(); | ||
| this.createStandingInstructionsForm.controls['toClientId'].disable(); | ||
| this.ToOfficeId = true; | ||
| this.ToClientId = true; |
There was a problem hiding this comment.
So it is disabled anyway?
There was a problem hiding this comment.
Actually, disable() method, it not only prevents the user from interacting with form but also excludes it from the form values when the form is submitted.
There was a problem hiding this comment.
The request going to the backend did not include the values for 'ToOfficeID' and 'toClientId'
There was a problem hiding this comment.
When a client selects destination: own account, then we need to disable TofficeId and Benefeciary and it should inherit the office and same client details in the API and from UI
There was a problem hiding this comment.
i dont really understand how it is doing this... :/
There was a problem hiding this comment.
Actually @adamsaghy we didn't want to exclude the toOfficeId and toClientId, we just wanted to grey out those filling in the form.
disable() method in .ts grey. out the filling and also exclude those keys from the form, that's why I removed the .diable() method
There was a problem hiding this comment.
so it is always greyed out?
if i understand correctly at init it is marked as disabled and i dont see any logic which would change it.
There was a problem hiding this comment.
No not always greyed out, it is only gryed out after we select destination as it own account
There was a problem hiding this comment.
Test_Standing.mov
Description
now we can create standing instruction by using both destinations, previously
this.createStandingInstructionsForm.controls['toOfficeId'].disable();
diable() was excluding the form values too, therefore it was not woking
Related issues and discussion
#1932
Screenshots, if any
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
If you have multiple commits please combine them into one commit by squashing them.
Read and understood the contribution guidelines at
web-app/.github/CONTRIBUTING.md.