Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refractor: Migration of update password screen to compose #2564

Closed
wants to merge 4 commits into from
Closed

refractor: Migration of update password screen to compose #2564

wants to merge 4 commits into from

Conversation

itsPronay
Copy link
Contributor

@itsPronay itsPronay commented Apr 4, 2024 •
edited
Loading

fixes : #2561

Compose
image

screen recording -
Screencast_04_07_2024_04:29:57_AM.webm

@AvneetSingh2001
Copy link
Collaborator

AvneetSingh2001 commented Apr 4, 2024 •
edited
Loading

@itsPronay can you please edit your commit message to follow the commit guidelines.
Also ideally we should implement the whole screen in compose, So please make use of Topbar and ProgressIndicator of Compose rather than using the old way.

@itsPronay
Copy link
Contributor Author

@AvneetSingh2001 Okay!

@itsPronay itsPronay force-pushed the refractor branch 4 times, most recently from 139485a to 2638de2 Compare April 5, 2024 03:27
@itsPronay
migrate update password screen to compose
6edc262 
migrate update password screen to compose

migrate update password screen  to compose

migrate update password screen to compose

Migration of update password screen to compose

Migration of update password screen to compose

migrate update update password to compose

migration of Update password screen to compose

Refractor: Migration of Update Password to compose

Refractor: Migration of Update Password to compose

migration of update password to compose

migrate Update password to compose

update Password to compose migration

update password screen from XML to Compose
@itsPronay
Copy link
Contributor Author

itsPronay commented Apr 5, 2024 •
edited
Loading

@AvneetSingh2001 Please take a look at my code and let me know if I should make any changes in it

@AvneetSingh2001
Copy link
Collaborator

I see you still have not used compose progress indicator. Also you need to collect the flows as state in the compose itself. please go through my recent PR for the reference.
Also me are aiming to eradicate fragments in the future, so migrate code in such a way that fragments should only be use return compose view.

@itsPronay
Copy link
Contributor Author

@AvneetSingh2001 Okay bro! thanks for reviewing. I will make the necessary changes ASAP

@itsPronay itsPronay marked this pull request as draft April 6, 2024 15:14
@itsPronay itsPronay force-pushed the refractor branch 3 times, most recently from d0167d1 to 38be1bb Compare April 6, 2024 22:24
@itsPronay itsPronay marked this pull request as ready for review April 6, 2024 22:33
@itsPronay itsPronay marked this pull request as draft April 6, 2024 23:24
@itsPronay
Revert "Merge branch 'openMF:development' into refractor"
2da6e8e 
This reverts commit f7b911e, reversing
changes made to 6edc262.
@itsPronay
Copy link
Contributor Author

I am really sorry. I have to close this one as it created conflicts + my git is now pretty messed up right now. I will be raising a new PR. Sorry about that...

@itsPronay itsPronay closed this Apr 7, 2024
@itsPronay itsPronay deleted the refractor branch June 23, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor: Migration of update password screen (XML to compose)
2 participants
@itsPronay @AvneetSingh2001