refactor: migrated savings account application screen to compose #2522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This screen does not follow the material guideline, please give 16dp padding from left and right.
|
|
hey, thats screenshot is actually the previous design in XML, that doesn’t have the padding. I have already given the padding in Compose design, you can check Compose screen recording here: |
therajanmaurya
requested changes
Mar 14, 2024
...ain/java/org/mifos/mobile/ui/savings_account_application/SavingsAccountApplicationContent.kt
Outdated
Show resolved
Hide resolved
...in/java/org/mifos/mobile/ui/savings_account_application/SavingsAccountApplicationFragment.kt
Outdated
Show resolved
Hide resolved
...in/java/org/mifos/mobile/ui/savings_account_application/SavingsAccountApplicationFragment.kt
Outdated
Show resolved
Hide resolved
...in/java/org/mifos/mobile/ui/savings_account_application/SavingsAccountApplicationFragment.kt
Outdated
Show resolved
Hide resolved
...in/java/org/mifos/mobile/ui/savings_account_application/SavingsAccountApplicationFragment.kt
Outdated
Show resolved
Hide resolved
...in/java/org/mifos/mobile/ui/savings_account_application/SavingsAccountApplicationFragment.kt
Outdated
Show resolved
Hide resolved
...main/java/org/mifos/mobile/ui/savings_account_application/SavingsAccountApplicationScreen.kt
Outdated
Show resolved
Hide resolved
...main/java/org/mifos/mobile/ui/savings_account_application/SavingsAccountApplicationScreen.kt
Outdated
Show resolved
Hide resolved
...main/java/org/mifos/mobile/ui/savings_account_application/SavingsAccountApplicationScreen.kt
Outdated
Show resolved
Hide resolved
AvneetSingh2001
force-pushed
the
savings_account_application_compose_migration
branch
from
ca96e7f to
0b1335c
Compare
| * Created by saksham on 30/June/2018 | ||
| */ | ||
| @AndroidEntryPoint | ||
| class SavingsAccountApplicationFragment : BaseFragment() { |
There was a problem hiding this comment.
Awesome Job! Now later on when we will implement compose navigation we only need to pick the compose and done.
therajanmaurya
approved these changes
Mar 15, 2024
therajanmaurya
requested changes
Mar 15, 2024
...n/java/org/mifos/mobile/ui/savings_account_application/SavingsAccountApplicationViewModel.kt
Outdated
Show resolved
Hide resolved
AvneetSingh2001
force-pushed
the
savings_account_application_compose_migration
branch
from
0b1335c to
076224a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2521
Please Add Screenshots If there are any UI changes.
Before(XML Screen):
https://github.com/openMF/mifos-mobile/assets/77102514/91c990b5-e8ff-47c8-865e-2893fe0461cd
After(Compose Screen):
https://github.com/openMF/mifos-mobile/assets/77102514/f17bc7d2-84e8-4099-8a6a-53e355685db1