refactor #2511: migrated savings account detail screen to compose #2512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
therajanmaurya
requested changes
Feb 14, 2024
|
|
||
| @JvmField | ||
| @Inject | ||
| var preferencesHelper: PreferencesHelper? = null |
There was a problem hiding this comment.
It is injected from hilt so It will not null ever. please remove nullable ? = null and @JvmField
| } | ||
|
|
||
| sealed class SavingsAccountDetailUiState { | ||
| data object Initial : SavingsAccountDetailUiState() |
There was a problem hiding this comment.
Why do we need Initial, I think Loading default is fine.
AvneetSingh2001
force-pushed
the
saving_account_details_migration
branch
from
695f30e to
428339d
Compare
AvneetSingh2001
force-pushed
the
saving_account_details_migration
branch
from
428339d to
1a7dfd2
Compare
# Conflicts: # app/src/main/java/org/mifos/mobile/ui/fragments/SavingAccountsDetailFragment.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2511
Please make sure these boxes are checked before submitting your pull request - thanks!
Apply the
AndroidStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.