Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: registration screen to compose #2459

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

PratyushSingh07
Copy link
Collaborator

@PratyushSingh07 PratyushSingh07 commented Dec 28, 2023

Fixes #2458
Fixes #1918

Original Design Light Theme Dark Theme
  • Apply the AndroidStyle.xml style template to your code in Android Studio.

  • Run the unit tests with ./gradlew check to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them.

@PratyushSingh07
Copy link
Collaborator Author

@therajanmaurya I have migrated the registration screen to compose as well. This PR also resolves #1918 , could you please review this at your convenience

@therajanmaurya therajanmaurya merged commit e3e2667 into openMF:development Jan 17, 2024
3 checks passed
@PratyushSingh07 PratyushSingh07 deleted the signup-compose branch January 22, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: migrate signup screen to compose Even selecting dark mode, register screen was in light mode
2 participants